Skip to content

Conversation

@karsharma10
Copy link
Contributor

@karsharma10 karsharma10 commented Dec 28, 2025

Summary

  • Rename TestFunctionCallTestFunctionCallDeprecated to clarify it tests the deprecated WithFunctions API
  • Add new TestFunctionCall test that uses the recommended WithTools API
  • Add httprr recording for the new test

Context

The WithFunctions option is deprecated in favor of WithTools. This change makes it explicit which test covers the deprecated API (for backward compatibility) and adds proper test coverage for the recommended API.

Recording

The httprr file was generated with:

cd llms/openai && go test -v -httprecord=. -run "TestFunctionCall$"

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

  Rename TestFunctionCall to TestFunctionCallDeprecated to make it clear
  this test covers the deprecated WithFunctions API. Rename TestFunctionCall2
  to TestFunctionCall since it tests the recommended WithTools API.
@karsharma10 karsharma10 deleted the llms/openai-rename-deprecated-function-test branch December 28, 2025 21:07
@karsharma10 karsharma10 restored the llms/openai-rename-deprecated-function-test branch December 29, 2025 02:53
@karsharma10 karsharma10 deleted the llms/openai-rename-deprecated-function-test branch December 29, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant