llms/openai: rename function call tests to clarify deprecated vs recommended API #1449
+131
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestFunctionCall→TestFunctionCallDeprecatedto clarify it tests the deprecatedWithFunctionsAPITestFunctionCalltest that uses the recommendedWithToolsAPIContext
The
WithFunctionsoption is deprecated in favor ofWithTools. This change makes it explicit which test covers the deprecated API (for backward compatibility) and adds proper test coverage for the recommended API.Recording
The httprr file was generated with:
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.