Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Feature request: Conversational Retrieval QA #208

Merged
merged 5 commits into from
Jul 23, 2023

Conversation

nidzola
Copy link
Contributor

@nidzola nidzola commented Jul 20, 2023

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Description

@ccbond
Copy link

ccbond commented Jul 23, 2023

looks great!

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example demonstrating use?

@tmc tmc merged commit c5715c5 into tmc:main Jul 23, 2023
3 checks passed
@nidzola
Copy link
Contributor Author

nidzola commented Jul 23, 2023

Can you add an example demonstrating use?

I've added a unit test, which is demoing the usage, not sure if you were thinking to have something else?

@nidzola nidzola deleted the feat-conversational-retrieval-qa branch July 23, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants