memory: Feature conversational retrieval interface fix and rename #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.Description
schema.Memory
instead of thememory.Buffer
, by that we can in future pass in any memory that we need (for example Buffer, TokenBuffer or any other that we add).Buffer
to beConversationBuffer
andTokenBuffer
to beConversationTokenBuffer
so that we are closer to the langchain python implementation, so that it is easier on the eyes when we are comparing what is what.ChatMessageHistory
schema to support errors, we need that when we port in psql, mongo or any other driven history, so that we don't swallow the errors when/if we have them