Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Feature conversational retrieval interface fix and rename #222

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

nidzola
Copy link
Contributor

@nidzola nidzola commented Jul 25, 2023

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Description

  • this PR fixes the Conversational retrieval interface to accept schema.Memory instead of the memory.Buffer, by that we can in future pass in any memory that we need (for example Buffer, TokenBuffer or any other that we add).
  • I've also renamed Buffer to be ConversationBuffer and TokenBuffer to be ConversationTokenBuffer so that we are closer to the langchain python implementation, so that it is easier on the eyes when we are comparing what is what.
  • updated ChatMessageHistory schema to support errors, we need that when we port in psql, mongo or any other driven history, so that we don't swallow the errors when/if we have them

@nidzola
Copy link
Contributor Author

nidzola commented Jul 25, 2023

@tmc if you could check this out, would like to merge it, b/c it fixes the Conversational retrieval.

@tmc tmc merged commit 6e4a77e into tmc:main Jul 26, 2023
3 checks passed
@nidzola nidzola deleted the feature-conversational-retrieval-interface-fix branch July 26, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants