Skip to content

vectorstore/options: Extending Vectorstore options to accept optional embedder #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2023
Merged

vectorstore/options: Extending Vectorstore options to accept optional embedder #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39904df
vectorstore-embedder-options | extendting vectrstore options
zivkovicn Aug 11, 2023
1552263
Merge branch 'main' into vectorstore-embedder-options
nidzola Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions vectorstores/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package vectorstores

import "github.com/tmc/langchaingo/embeddings"

// Option is a function that configures an Options.
type Option func(*Options)

Expand All @@ -8,6 +10,7 @@ type Options struct {
NameSpace string
ScoreThreshold float64
Filters any
Embedder embeddings.Embedder
}

// WithNameSpace returns an Option for setting the name space.
Expand All @@ -32,3 +35,12 @@ func WithFilters(filters any) Option {
o.Filters = filters
}
}

// WithEmbedder returns an Option for setting the embedder that could be used when
// adding documents or doing similarity search (instead the embedder from the Store context)
// this is useful when we are using multiple LLMs with single vectorstore.
func WithEmbedder(embedder embeddings.Embedder) Option {
return func(o *Options) {
o.Embedder = embedder
}
}