Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callbacks: add standard interface and logger #257

Merged
merged 12 commits into from
Aug 26, 2023
Merged

Conversation

FluffyKebab
Copy link
Collaborator

This adds an interface for callbacks and incorporates it into tools, the agent executor, the vector store retriever, all LLMs and the LLM chain. Incorporating callbacks into all chains is yet do be done.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

// Handler is the interface that allows for hooking into specific parts of an
// LLM application.
type Handler interface {
HandleText(text string)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should propagate ctx in these calls, thoughts?

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, comment on the interface.

@tmc
Copy link
Owner

tmc commented Aug 26, 2023

I went ahead and rebased and threaded ctx through.

@tmc tmc enabled auto-merge August 26, 2023 02:23
@tmc tmc merged commit 9f51407 into tmc:main Aug 26, 2023
3 checks passed
This was referenced Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants