-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend ANALYZE common syntax to cover multiple dialects #4591
Conversation
@zashroof, no need to spend too much time on Drill and Doris, they're low priority dialects. |
@zashroof first of all, great work!
|
Done
Done
Done
Done
I tried to parse |
@zashroof Nice update. Did you also check the rest of the Check here:
In the above cases, if the implementation is too complex, we mostly need the fallback mechanism ( treat the whole input as |
@geooo109 Added |
hehe github git operation is experiencing a major outage. Can't push my last commit. |
Thank you for the quick iterations @zashroof, we'll take another look soon :) |
Appreciate the contribution @zashroof! |
Thanks for bearing with me through the review! |
Continuing on #4547, extending the common
ANALYZE
parse common logic to cover more dialects.Analyze
statement reference