Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a problem when using
sqlglot
in Apache Superset to process (parse, modify the AST, and re-render) Firebolt queries. The problem happens when we run a query with a predicate ofcol NOT IN
and it gets translated toNOT col IN
by the generic parser:While both queries are semantically equivalent, the first one is valid in Firebolt, while the second is not. This happens because
NOT
has higher precedence thanIN
:This only happens when checking for a range; equality (and other comparisons) works as expected:
This PR introduces a custom Firebolt dialect that fixes the problem: