Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Fix all ShellCheck errors and most warnings #419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Aug 16, 2023

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

This improves the code quality of todo.sh by fixing all warnings and most errors. There are now only a few remaining (low-priority, mostly "info") lints from ShellCheck.

QA/Testing:

make test

@hyperupcall
Copy link
Contributor Author

@inkarkat Is there anything else that needa to be done? Or just waiting to be merged

@inkarkat
Copy link
Member

@hyperupcall This PR is looking good, relax ;-)

I've suggested to @karbassi to first do a release (last one's been 4 years ago!), and then incorporate more outstanding PRs, followed by another release shortly thereafter. But I don't know whether he has the time, or first wants to add more maintainers and document the release process?!

@hyperupcall
Copy link
Contributor Author

@inkarkat Ah, I understand, yeah it's probably best to do a release first. I suppose we'll see what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants