Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated ErrorDetail component to conditionally display text #9575

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

Innei
Copy link

@Innei Innei commented Jan 7, 2025

No description provided.

…rror" or "Show error" based on the stack trace visibility.
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ lawvs
✅ L-Sun
❌ Innei
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

graphite-app bot commented Jan 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Jan 7, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.66%. Comparing base (53e5726) to head (a2468e1).
Report is 119 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9575      +/-   ##
==========================================
- Coverage   53.66%   53.66%   -0.01%     
==========================================
  Files        2288     2288              
  Lines      104683   104683              
  Branches    17420    17421       +1     
==========================================
- Hits        56176    56175       -1     
+ Misses      47140    47139       -1     
- Partials     1367     1369       +2     
Flag Coverage Δ
server-test 78.10% <ø> (ø)
unittest 31.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun changed the title chore: Updated ErrorDetail component to conditionally display "Hide error" or "Show error" based on the stack trace visibility. chore: Updated ErrorDetail component to conditionally display "Hide error" or "Show error" based on the stack trace visibility Feb 11, 2025
@L-Sun L-Sun changed the title chore: Updated ErrorDetail component to conditionally display "Hide error" or "Show error" based on the stack trace visibility chore: updated ErrorDetail component to conditionally display "Hide error" or "Show error" based on the stack trace visibility Feb 11, 2025
@lawvs lawvs changed the title chore: updated ErrorDetail component to conditionally display "Hide error" or "Show error" based on the stack trace visibility chore: updated ErrorDetail component to conditionally display text Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants