chore(editor): update default colors of shape #9633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9633 +/- ##
=======================================
Coverage 52.83% 52.83%
=======================================
Files 2180 2180
Lines 98568 98569 +1
Branches 16760 16760
=======================================
+ Hits 52080 52081 +1
Misses 45043 45043
Partials 1445 1445
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fundon
force-pushed
the
fundon/01_10_update_default_colors_of_shape
branch
from
d025ecd to
48842aa
Compare
fundon
force-pushed
the
fundon/01_10_update_default_colors_of_shape
branch
2 times, most recently
from
c2795bc to
9b140c6
Compare
graphite-app
bot
requested review from
EYHN,
pengx17,
JimmFly and
CatsJuice
and removed request for
EYHN
fundon
force-pushed
the
fundon/01_10_update_default_colors_of_shape
branch
5 times, most recently
from
43c797c to
a4b8f5c
Compare
EYHN
approved these changes
Jan 13, 2025
Merge activity
|
Closes: [PD-2176](https://linear.app/affine-design/issue/PD-2176/edgeless-shape默认颜色调整) * updates shape's text color to the `#000000ff` and custom button should be selected by default in color picker * updates shape background default color palette to `medium` <img width="727" alt="Screenshot 2025-01-13 at 11 07 14" src="https://github.com/user-attachments/assets/81962741-0dbc-4990-8eec-db5e48624305" /> <img width="444" alt="Screenshot 2025-01-13 at 11 07 09" src="https://github.com/user-attachments/assets/2d119e33-635e-4bd4-826f-e3094c8a3fa2" /> <img width="764" alt="Screenshot 2025-01-13 at 11 08 14" src="https://github.com/user-attachments/assets/09f5c778-0e25-4972-8529-8d8323c27594" />
fundon
force-pushed
the
fundon/01_10_update_default_colors_of_shape
branch
from
a4b8f5c to
7e5e603
Compare
graphite-app
bot
deleted the
fundon/01_10_update_default_colors_of_shape
branch
fundon
added a commit
that referenced
this pull request
Jan 20, 2025
part of: #9633 * updates fill color in `shape.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: PD-2176
#000000ffand custom button should be selected by default in color pickermedium