Skip to content

Conversation

@fengmk2
Copy link
Collaborator

@fengmk2 fengmk2 commented Jan 13, 2025

No description provided.

Copy link
Collaborator Author

fengmk2 commented Jan 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 7d391ce to 638d63e Compare January 13, 2025 04:57
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from ebe0bd2 to bbe71b9 Compare January 13, 2025 04:57
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 638d63e to 4f02573 Compare January 13, 2025 09:10
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from bbe71b9 to 184532f Compare January 13, 2025 09:11
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 4f02573 to c0e324e Compare January 13, 2025 09:12
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 184532f to 8425c4f Compare January 13, 2025 09:12
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from c0e324e to e72a1d4 Compare January 13, 2025 09:20
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 8425c4f to 503675a Compare January 13, 2025 09:20
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from e72a1d4 to 6c02e21 Compare January 13, 2025 09:53
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 503675a to c68ef6d Compare January 13, 2025 09:53
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 6c02e21 to b44d04f Compare January 13, 2025 10:08
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from c68ef6d to 902b91b Compare January 13, 2025 10:08
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch 3 times, most recently from 812b46c to 5d24b7b Compare January 14, 2025 01:37
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from a5a9708 to 42336b5 Compare January 14, 2025 03:23
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 5d24b7b to 7b271e4 Compare January 14, 2025 03:23
@fengmk2 fengmk2 changed the base branch from 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice to graphite-base/9660 January 14, 2025 03:39
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 7b271e4 to 01a4f3e Compare January 14, 2025 03:56
@fengmk2 fengmk2 force-pushed the graphite-base/9660 branch from 42336b5 to ee99b0c Compare January 14, 2025 03:56
@fengmk2 fengmk2 changed the base branch from graphite-base/9660 to canary January 14, 2025 03:57
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 01a4f3e to 6da1ebc Compare January 14, 2025 03:57
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.08%. Comparing base (ee99b0c) to head (b7635c8).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/core/auth/service.ts 92.85% 2 Missing ⚠️
packages/backend/server/src/core/auth/job.ts 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9660      +/-   ##
==========================================
+ Coverage   52.86%   53.08%   +0.21%     
==========================================
  Files        2196     2197       +1     
  Lines       98956    98871      -85     
  Branches    16826    16867      +41     
==========================================
+ Hits        52313    52482     +169     
+ Misses      45199    44946     -253     
+ Partials     1444     1443       -1     
Flag Coverage Δ
server-test 78.80% <94.00%> (+0.81%) ⬆️
unittest 32.17% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2025

Merge activity

@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_session_model_in_auth_service branch from 6da1ebc to b7635c8 Compare January 14, 2025 07:43
@graphite-app graphite-app bot merged commit b7635c8 into canary Jan 14, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-13-refactor_server_use_session_model_in_auth_service branch January 14, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:server test Related to test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants