Skip to content

Conversation

@tottoto
Copy link
Collaborator

@tottoto tottoto commented Jan 10, 2026

Improves the test-msrv job cache.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to do sth. like tower-rs/tower-http#635 as well? Then we don't need a nightly toolchain anymore.

@tottoto
Copy link
Collaborator Author

tottoto commented Jan 10, 2026

The test-msrv job currently checks both the MSRV build and the minimal dependencies versions build. If it is changed to check only the MSRV build using that approach, a separate job will be needed to verify the build with the minimal dependencies versions, and that job will still require nightly, which is the same approach to the hyper project.

@jplatte
Copy link
Member

jplatte commented Jan 11, 2026

Right, I guess testing min-versions as well is kinda nice. Though the amount of workarounds needed there is a bit ridiculous. How do you feel about testing msrv in the way I proposed, plus min-direct-versions? I'm pretty sure there's a separate nightly-only flag for that.

@tottoto
Copy link
Collaborator Author

tottoto commented Jan 11, 2026

I think it's reasonable. I'll open a pull request to separate these checks.

@tottoto tottoto merged commit f829daf into tokio-rs:main Jan 11, 2026
18 checks passed
@tottoto tottoto deleted the improve-test-msrv-cache branch January 11, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants