feat: add support for vsock connections #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This looks good in general. Would you mind adding a bit more background and justification to your PR message (that will go into the commit history). Basically because I didn't know what a vsock was until today, so I figure the reference would be worthwhile. 😅 |
|
@hds done :) |
|
Friendly ping :) |
|
@domenkozar Thanks for the ping. I've just had another look through the PR, however don't we need to add vsock support into tokio-console as well? Otherwise this feels like only half the feature. |
|
@hds something like this? :) |
hds
requested changes
Apr 14, 2025
|
PTAL :) |
hds
approved these changes
Apr 14, 2025
hds
changed the title
This allows connecting to VSOCK address family, which is used in VMs: https://man7.org/linux/man-pages/man7/vsock.7.html
|
@domenkozar Merged! Thanks for your contribution! I hope to get a release of the crates out in the next week. There are just a few little changes that we'd like to make first. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hidden it behind a feature flag, since it's kind of uncommon.