Bump changes to 0.51.0 Changes Version #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dikasetiadi
requested review from
jeffersonsetiawan and
wendyliga
as code owners
Comment on lines
+10
to
+18
| // MARK: - Deprecated after 0.50.4 | ||
|
|
||
| @available( | ||
| *, | ||
| deprecated, | ||
| message: "Use 'Effect<Action>.Send' instead." | ||
| ) | ||
| public typealias Send<Action> = Effect<Action>.Send | ||
|
|
There was a problem hiding this comment.
please try to remove this (I don't think we have any usage of send yet)
There was a problem hiding this comment.
this one is from pointfreeco/swift-composable-architecture#1911
it was also used internally by some core like store etc. so this one for also the warning if the codes use Send (if we pulling another core codes later on, we can see warning and change it into new one) wdyt gan? @jeffersonsetiawan
There was a problem hiding this comment.
If we remove this code and there is no error, I think we can go to remove it dik, as Toko is not using this Send code yet CMIIW
jeffersonsetiawan
approved these changes
Jan 3, 2024
jeffersonsetiawan
pushed a commit
that referenced
this pull request
Jan 3, 2024
* empty commit * Bump changes to 0.50.1 Changes Version (#106) * update to changes PR #1879 * add changes from #1882 * fix build on xcode 13.4.1 * Bump changes to 0.50.2 Changes Version (#107) * apply changes from #1883 * apply changes from #1890 * apply changes from #1893 * apply changes from #1897 * Bump changes to 0.50.3 Changes Version (#108) * update package.swift & missmatch version podspec * apply partial changes from #1907 * Bump changes to 0.51.0 Changes Version (#109) * apply partial changes from #1917 * fix test on RxTca * apply changes from #1911 * apply changes from #1920 * apply changes from #1900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff changes:
pointfreeco/swift-composable-architecture@0.50.3...0.51.0
Log Skipped Commit:
https://docs.google.com/spreadsheets/d/17HLbCxUc6r0kFAfIIB42-HAIZDBMI7wWUZiUovBfkEU/edit?pli=1#gid=1960877626