-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use mio instead of tiny-http #144
base: master
Are you sure you want to change the base?
Conversation
What's the status on this work? It could be good to combine this with #154 as a new major version (realistically for a major version bump I'd drop rustc-serialize entirely). |
The code here is working, but it's not tested. |
What would the process be to get this PR and the Serde PR implemented? These two PRs would be a great boost for the project though I'm sure other concerns come in to play here. |
Well the Serde update is ready for review. It has obvious backwards compat issues so there is a question there.
|
So the problem with this PR right now is that it breaks websockets. Other than that, I think there are some minor problems such as HTTP error codes not being returned in some situations (eg. request line too long), and performances could be improved. |
The performance gains from this PR are really impressive! Running the I did notice two issues though:
|
Thanks for the investigation! That's unfortunate. |
cc #27