fix(src/withGoogleMap): crash when google is not defined#867
Open
ToLi91 wants to merge 1 commit intotomchentw:masterfrom
Open
fix(src/withGoogleMap): crash when google is not defined#867ToLi91 wants to merge 1 commit intotomchentw:masterfrom
ToLi91 wants to merge 1 commit intotomchentw:masterfrom
Conversation
Author
|
The withGoogleMap function doesn't prevent "google is not loaded" error. I proposed a solution to this in In my case, my system operates offline too and this crash is right. |
Author
|
That will only work if the variable google has been defined to a falsely state. I have the problem where google is not yet defined due to that I did not allow the google maps js to load (NoScript). I think both of these solutions are very good improvements which solves two different problems. |
|
It seems to be the same problem that #811. There it was solved |
Author
|
@mauriciosfriso yes this is very true! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE CHECK "Allow edits from maintainers"
FOLLOW "Conventional Commits Specification" FOR ALL COMMITS
https://conventionalcommits.org/