Upgrade webrtc-audio-processing lib to v2.0 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strohel
reviewed
Jan 14, 2025
Member
strohel
left a comment
strohel
left a comment
There was a problem hiding this comment.
Just a pass by review, looks good on paper
Comment on lines
+103
to
+118
| impl From<CaptureLevelAdjustment> for ffi::AudioProcessing_Config_CaptureLevelAdjustment { | ||
| fn from(other: CaptureLevelAdjustment) -> Self { | ||
| let analog_mic_gain_emulation = | ||
| ffi::AudioProcessing_Config_CaptureLevelAdjustment_AnalogMicGainEmulation { | ||
| enabled: false, | ||
| initial_level: 255, | ||
| }; | ||
|
|
||
| Self { | ||
| enabled: true, | ||
| pre_gain_factor: other.pre_gain_factor, | ||
| post_gain_factor: other.post_gain_factor, | ||
| analog_mic_gain_emulation, | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Optional nit: we could instead implement impl From<Option<CaptureLevelAdjustment>> for ffi::AudioProcessing_Config_CaptureLevelAdjustment { and set enabled: false if it is None - i.e. move some logic from the caller to here.
OTOH I guess this pattern is used for many types here, so we shuold probably either convert either all or none - which is better suited for a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It builds, but functionalities haven't been tested.