fix: WASM HTTP client status propagation and Content-Length signature mismatch #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mismatch Two bugs fixed that prevented AWS S3-compatible storage from working in WASM environments: 1. Missing HTTP status code propagation - The WASM HTTP client wasn't copying the response status from reqwest, causing it to default to 200. This masked 403/404 errors and led to confusing "missing ETag" errors. 2. Content-Length header causes signature mismatch - Browser's fetch API modifies/strips the Content-Length header on requests with empty bodies. When the header was included in AWS signature calculation but then modified by fetch, R2/S3 rejected requests with SignatureDoesNotMatch. Changes: - wasm.rs: Propagate response status code; remove Content-Length before sending - fs.rs: Remove Content-Length from HEAD, GET (list), DELETE requests - s3.rs: Remove Content-Length from GET (range read), HEAD requests - head.rs: Remove Content-Length from GET request - multipart_upload.rs: Remove Content-Length from POST, PUT (copy) requests - pre-commit: Remove broken fusio-manifest std-only checks (requires executor) Tested with: - Cloudflare Workers + R2 (WASM target) - Native S3 via tonbo's s3_smoke test (tokio target)
belveryin
changed the title
belveryin
changed the title
ethe
approved these changes
Dec 19, 2025
Member
|
Nice catch! Thank you Daniel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing HTTP status code propagation - The WASM HTTP client wasn't copying
the response status from reqwest, causing it to default to 200. This masked
403/404 errors and led to confusing "missing ETag" errors.
Content-Length header causes signature mismatch - Browser's fetch API
modifies/strips the Content-Length header on requests with empty bodies.
When the header was included in AWS signature calculation but then modified
by fetch, R2/S3 rejected requests with SignatureDoesNotMatch.
Changes:
Tested with: