Skip to content

Fix detecting interfaces of non-emulated accounts #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

dungeon-master-666
Copy link
Collaborator

No description provided.

Copilot

This comment was marked as outdated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes interface detection for non-emulated accounts in the trace by extending the detection process to include all accounts referenced in the trace, not just the emulated ones.

  • Adds logic to detect interfaces for non-emulated accounts that appear in the trace
  • Introduces helper methods to collect all addresses from the trace tree structure
  • Updates comments to clarify the distinction between emulated and non-emulated account processing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
TraceInterfaceDetector.cpp Adds interface detection for non-emulated accounts and includes necessary header
TraceEmulator.h Adds get_addresses() methods to collect all addresses from trace tree
Comments suppressed due to low confidence (1)

ton-index-worker/ton-trace-emulator/src/TraceInterfaceDetector.cpp:50

  • [nitpick] The actor name "fetchaccountfromshard" should follow consistent naming conventions. Consider using a more descriptive name or matching the class name format like "FetchAccountFromShard".
        td::actor::create_actor<FetchAccountFromShardV2>("fetchaccountfromshard", shard_states_, address, std::move(P)).release();

@dungeon-master-666 dungeon-master-666 merged commit 8178284 into master Jul 25, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant