Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added � and ⚠ #1175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added � and ⚠ #1175

wants to merge 3 commits into from

Conversation

gjvnq
Copy link
Contributor

@gjvnq gjvnq commented Dec 24, 2020

No description provided.

@tonsky
Copy link
Owner

tonsky commented Dec 28, 2020

Wow, thanks. But

75,971 additions, 73,603 deletions

Not sure how to merge this. Also

- .appVersion = "1348";
+ .appVersion = "3039";
+ .formatVersion = 3;

I haven’t bought the new version yet (not sure if will).

Any way you can isolate just the outlines? Would be happy to merge those

@gjvnq
Copy link
Contributor Author

gjvnq commented Dec 29, 2020 via email

@gjvnq
Copy link
Contributor Author

gjvnq commented Dec 29, 2020

I redid my work and I hope it can now work on the old version of the app.

@tonsky
Copy link
Owner

tonsky commented Dec 29, 2020

Thank you, I merged U+FFFD as a755aab.

About ⚠, I am not sure: I don’t like how it looks. Maybe base it on equilateral triangle?

This is how it looks in your PR:

Screenshot 2020-12-29 at 18 36 57

Screenshot 2020-12-29 at 18 37 02

These are some other characters from the font that look more fira code-like.

Screenshot 2020-12-29 at 18 37 13

Screenshot 2020-12-29 at 18 37 45

Screenshot 2020-12-29 at 18 38 13

I also feel that line width should match stem width.

@tonsky
Copy link
Owner

tonsky commented Dec 29, 2020

The actual commit is 415c773 (forgot to update CHANGELOG.md)

@itsMo07
Copy link

itsMo07 commented Mar 4, 2021

Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants