Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added APL symbols from miscellaneous technical block #1460

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Tortus-exe
Copy link

symbols added:

  • ring operator (∘)
  • diamond operator (⋄)
  • Left Ceiling (⌈)
  • Left Floor (⌊)
  • Unicode symbols from U+2336 to U+237A
  • U+2395 APL functional symbol Quad (⎕)

Sorry if it's a lot, but it really would be amazing to have APL symbols in Fira Code.

@tonsky
Copy link
Owner

tonsky commented Aug 15, 2022

Thanks! I’ll take a look soon

@tonsky
Copy link
Owner

tonsky commented Aug 22, 2022

Looks like most APL symbols are missing bold version? You also are not using components, which will be much easier to support in the future, if any of those will require alterations. Could you make that change? Or I can do it myself later

@tonsky tonsky added the Unicode label Aug 22, 2022
@tonsky tonsky added this to the 7 milestone Aug 22, 2022
@Tortus-exe
Copy link
Author

Thank you for letting me know. I'll try to fix those things.

@Tortus-exe
Copy link
Author

As requested, I have changed glyphs to use components. However there is still no bold font since I am using Glyphs Mini, which purportedly doesn't support multiple masters. I am currently unable to upgrade to a paid version as well. If there's anything I can do that does not involve money, I may be able to do it. Sorry about that. But I hope the light version will be good enough to extrapolate the boldface.

As a side note, it seems that Glyphs Mini also doesn't support masking components, so I was unable to add some. APLQuadUpArrow is an example where the sides of the arrow were clipped and the tail made longer, but since I cannot do that to a component I was unable to replace the arrow portion. Similar situation with some of the four vanes.

Again, please don't hesitate to comment or say something if there's something else I missed! Thank you for the fast reply last time. :)

@Tortus-exe
Copy link
Author

OH and I almost forgot - one last change: I moved the glyph WhiteCircle up to match the height of other symbols using the LargeCircle component like circle stile and circle backslash. No symbols use the whiteCircle glyph as a component though.

@tonsky
Copy link
Owner

tonsky commented Aug 23, 2022

Thank you! Yeah, I know, contributing is a pain because Glyphs costs a lot, so I don’t expect anyone to buy it. I’ll take it from there, adding bold versions should be easier with components. Thanks!

@Tortus-exe
Copy link
Author

Tonsky, would it be possible to change some of the base glyphs to fit better with the APL glyphs? namely the mathematical "member of" (∊) glyph and the (∘) glyph? I just received feedback on the glyphs I made, so I may want to make a few minor changes to the additional glyphs as well.

@tonsky
Copy link
Owner

tonsky commented Sep 20, 2022

You mean in your PR? Yes, I have not touched it yet

@Tortus-exe
Copy link
Author

Tonsky, it might be a lot to ask, but would you be able to wrangle with ttf files? I am currently unable to edit the glyphs file, and am a bit stuck for options to contribute. My only idea right now is to create a ttf file or something along those lines that contains polished contributions.
I'm open to any other ideas! Please let me know.

@tonsky
Copy link
Owner

tonsky commented Nov 10, 2022

I can copy glyphs from TTF

@Tortus-exe
Copy link
Author

I've pushed an OTF file containing the extra glyphs, although, if I was able to get glyphs or edit glyph files in any way, there are quite a few character components I would use.

If only....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants