Skip to content

Conversation

@rsafonseca
Copy link
Contributor

No description provided.

@L30Bola
Copy link
Contributor

L30Bola commented Sep 11, 2024

I think that today our whole login is inside of the Reconcile method and this MR shows that. If we want to use the same logic "elsewhere" (in this case it is not elsewhere as we are implementing inside the Reconcile method but I think it should be elsewhere) we would need to copy/paste a lot, if not everything. We should add a TODO on our tasks to actually split the logic from Reconcile into a package (and maybe even more than one package) and Reconcile would only use the package methods and the dry-run itself should be elsewhere (maybe even another codebase/program).

This won't be easy, as I was discussing with @rafatio and he said: "it's not easy to join some of the logic inside a single package". So, yeah, I think that today it's okay the MR but we should do this split in the future.

@rafatio rafatio force-pushed the cmdline branch 2 times, most recently from f0cfcb0 to 094905e Compare June 16, 2025 13:39
@rafatio rafatio force-pushed the cmdline branch 3 times, most recently from 044e421 to 47a7962 Compare June 24, 2025 20:16
@rafatio rafatio merged commit 39d9e43 into main Sep 16, 2025
5 checks passed
@rafatio rafatio deleted the cmdline branch September 16, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants