Validation rooms accepts occupied as valid status #689
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| timeoutContext, | ||
| gameRoom, | ||
| []game_room.GameRoomStatus{game_room.GameStatusReady, game_room.GameStatusError}, | ||
| []game_room.GameRoomStatus{game_room.GameStatusReady, game_room.GameStatusOccupied, game_room.GameStatusError}, |
There was a problem hiding this comment.
Bug: Missing Case for GameStatusOccupied
The switch statement on line 211 handles GameStatusReady and GameStatusError, but does not have a case for GameStatusOccupied, which was added to the acceptable statuses list on line 201. When the room reaches GameStatusOccupied, the switch falls through without handling it explicitly, causing the function to return nil (success) without any logging or explicit confirmation that this state is valid. While the implicit behavior works, there should be an explicit case for GameStatusOccupied to properly handle and log this valid state, similar to how GameStatusReady is handled.
No description provided.