Skip to content

Conversation

@joaobologna
Copy link
Collaborator

@joaobologna joaobologna commented Dec 4, 2025

Adds roomValidationAcceptOccupiedStatus config option (default: false) that allows the new version validation process to accept rooms with GameStatusOccupied status as valid. This is useful when validation rooms may be picked up by the matchmaker before reporting GameStatusReady, preventing validation errors in such scenarios.


Note

Adds a configurable flag to treat GameStatusOccupied as a successful validation status during new scheduler version rollout.

  • Core (scheduler new version validation):
    • Update internal/core/operations/schedulers/newversion/executor.go:
      • Extend Config with RoomValidationAcceptOccupiedStatus.
      • During validation, include GameStatusOccupied in accepted statuses when flag is enabled; treat it as success.
  • Service config wiring:
    • Update internal/service/config.go to read services.roomManager.roomValidationAcceptOccupiedStatus and pass it into newversion.Config.
  • Config:
    • Add services.roomManager.roomValidationAcceptOccupiedStatus: false to config/config.yaml (default false).
  • Tests:
    • Add unit test in internal/core/operations/schedulers/newversion/executor_test.go verifying success when room reports GameStatusOccupied with flag enabled.

Written by Cursor Bugbot for commit 47cfbf0. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants