-
Notifications
You must be signed in to change notification settings - Fork 514
feat: customize error codec #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pipiaha
wants to merge
23
commits into
topfreegames:main
Choose a base branch
from
pipiaha:feat/custom_error_wrap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # builder.go
# Conflicts: # builder.go # conn/message/message_encoder.go
# Conflicts: # pkg/conn/message/message_decoder.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
ErrorWrapperinterface and its default implementation to handle error serialization and deserialization more effectively. The changes impact multiple files, primarily focusing on theserializepackage and its integration with theBuilderstruct.Error Handling Improvements:
ErrorWrapperinterface and its default implementationpitayaErrWrapperto handle custom error serialization and deserialization. (pkg/serialize/serializer.go) [1] [2]GetErrorFromPayloadandGetErrorPayloadfunctions to use the newDefaultErrWrapperfor error handling. (pkg/util/util.go)Builder Enhancements:
ErrWrapperfield to theBuilderstruct to allow custom error wrappers. (pkg/builder.go)Buildmethod to set theDefaultErrWrapperifErrWrapperis provided. (pkg/builder.go)Dependency Updates:
pkg/serialize/serializer.go)also see #371