Fixes for #1188; custom_commands broken

[GideonBear]

@themadprofessor You had some mistakes in #1188 which we both didn't spot:

• CustomCommands is broken and running pre_commands instead.
• NixHelper and Remotes are missing from default_steps
• Pkg is missing from default_steps on target_os = "android"

A few other changes:

• I added a few more *self where I could.
• Combined step-enum-sorted and step-match-sorted into custom-checks
• Added default_steps custom check to check if it contains every step
• Refactored default_steps to contain less overlapping cfg calls

@themadprofessor please review when you can.

[GideonBear]

Never mind, I cannot merge this myself. @SteveLauC could you review and merge as soon as possible?

[AThePeanut4]

IMO, I prefer the way step ordering was defined before #1188, with separate blocks for each OS, even if they have overlap. It makes it easier to see at a glance which steps will be run for each OS.

So I think the system-specific section of default_steps() should look more like this:

#[cfg(windows)]
steps.extend_from_slice(&[Wsl, WslUpdate, Chocolatey, Scoop, Winget, System, MicrosoftStore]);

#[cfg(target_os = "macos")]
steps.extend_from_slice(&[BrewFormula, BrewCask, Macports, Xcodes, Sparkle, Mas, System]);

#[cfg(target_os = "dragonfly")]
steps.extend_from_slice(&[Pkg, Audit]);

#[cfg(target_os = "freebsd")]
steps.extend_from_slice(&[Pkg, System, Audit]);

#[cfg(target_os = "openbsd")]
steps.extend_from_slice(&[Pkg, System]);

#[cfg(target_os = "android")]
steps.push(System);

#[cfg(target_os = "linux")]
steps.extend_from_slice(&[
    System,
    ConfigUpdate,
    AM,
    AppMan,
    DebGet,
    Toolbx,
    Snap,
    Pacstall,
    Pacdef,
    Protonup,
    Distrobox,
    DkpPacman,
    Firmware,
    Restarts,
    Flatpak,
    BrewFormula,
    Lure,
    Waydroid,
    AutoCpufreq,
    CinnamonSpices,
]);

So even though the System step is duplicated several times, it is really easy to see the list of steps that any particular system will run.

[GideonBear]

IMO, I prefer the way step ordering was defined before #1188, with separate blocks for each OS, even if they have overlap. It makes it easier to see at a glance which steps will be run for each OS.

I agree actually, I did not realize that #1188 added any overlap, I thought that was there before.

I noticed "android" should run Pkg (#1188 forgot that), not System, but I mostly used your example. Thx!

[themadprofessor]

Good spots. Having the target_os steps split up is definitely a better choice. All looks good to me.

[AThePeanut4]

LGTM 👍