Stochastic discrete gradient #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' into stochastic-discrete-gradient
Collaborator
|
TODO:
|
Collaborator
|
Collaborator
|
@thom-dani bug report
the problem is that there is a gradient caching mechanism and that mechanism needs to be disabled if the gradient parameters (backend, seed) change from one execution to the next. thanks for fixing this ASAP and letting me know when this is done. |
…into stochastic-discrete-gradient
…into stochastic-discrete-gradient
Collaborator
|
hi @thom-dani , thanks for the hot fix.
|
Contributor
Author
|
Hello @julien-tierny, I fixed the bug and I don't observe the behavior you described anymore. |
Collaborator
|
alright, the bug is fixed. The features are working as expected now! |
Collaborator
|
new bug report:
|
| std::vector<char> isPL; | ||
| this->discreteGradient_.getCriticalPointMap(criticalPoints, isPL); | ||
|
|
||
| // dmt1Saddle2PL_.resize(triangulation.getNumberOfEdges()); |
| Timer t; | ||
|
|
||
| const bool allowBoundary = true; | ||
| // const bool returnSaddleConnectors = false; |
| isRemovableSaddle.resize(numberOfEdges); | ||
|
|
||
| std::vector<int> dmt1Saddle2PL_(numberOfEdges, -1); | ||
| // dmt1Saddle2PL_.resize(numberOfEdges); |
| isRemovableSaddle.resize(numberOfTriangles); | ||
|
|
||
| std::vector<int> dmt2Saddle2PL_(numberOfTriangles, -1); | ||
| // dmt2Saddle2PL_.resize(numberOfTriangles); |
|
|
||
| if(vpath.isValid_) { | ||
| // add persistence pair to collection if necessary | ||
| // if(CollectPersistencePairs and outputPersistencePairs_) { |
Collaborator
There was a problem hiding this comment.
comments to remove as well.
Collaborator
|
ok, the code looks good.
|
thom-dani
force-pushed
the
stochastic-discrete-gradient
branch
from
faac9a4 to
9c5a463
Compare
Collaborator
|
everything ok. TODO: |
Collaborator
|
alright, let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TTK!
Before submitting your pull request, please:
Review our Contributor Guidelines, in particular regarding code formatting (with clang-format) and continuous integration.
Please provide a quick description of your contributions below:
Implementation of stochastic discrete gradient.