-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assets to jQuery-File-Upload 9.8.0 #68
Conversation
@ipd yeah, the origin gem looks unmaintained for a while and I'm not sure it will be back on track. Anyway, I'm using my fork exactly with Rails 4.1.x. Didn't noticed any issues yet. |
@opti ok, thanks for getting back to me. |
Update assets to jQuery-File-Upload 9.8.0
@opti Hola! Thanks for this! I've been very busy at work. I've added you as a collaborator. |
Thanks @tors ! We should probably version the gem so that people who are on rails < 4.x will be able to continue to use the old version. Also, we should create a new example app for Rails 4.x. |
Thanks for merging this @tors |
hey @tors I've created a release tag v0.4.2, if you don't mind you can push it to rubygems |
@opti roger that! Thanks! |
You should probably add back the X-Requested-WIth Patch for the Iframe-Transport Middleware before making a new release, see commit d246fe6 for details. |
@felixbuenemann I'm not sure that this is a good idea to make those changes in that repo. This js file is copied from original repo. Making fixes here forces repo maintainers to always keep in mind this fix on every future assets upgrade. |
Jepp, that's what I though and it was rejected, see blueimp/jQuery-File-Upload#3291. The problem is that this repo used to have this patch, so not having it brakes the usage of the iframe transport middleware. Maybe the middleware could be changed to somehow detect the request without the extra header. |
@felixbuenemann I see. You're feel free to add it back while there is no another solution yet. |
I think the best solution is to remove the middleware, see #69 for reasons. |
This PR includes:
vendor/assets
toapp/assets
for Rails 4 compatibilitybasic-plus
,angularjs
orjquery-ui
versions