Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assets to jQuery-File-Upload 9.8.0 #68

Merged
merged 4 commits into from
Jan 8, 2015
Merged

Conversation

opti
Copy link
Collaborator

@opti opti commented Nov 24, 2014

This PR includes:

  • updated assets from jQuery-File-Upload v9.8.0
  • moved vendor/assets to app/assets for Rails 4 compatibility
  • couple more helpers for easy include basic-plus, angularjs or jquery-ui versions
  • updated README.md

@ipd
Copy link

ipd commented Jan 5, 2015

@opti I noticed your PR sitting here. So, is this gem currently unmaintained? Perhaps @tors has moved on or is too busy?

I'd like to use the gem, but am running Rails 4.1.x and am wondering what to do. Perhaps i should just use your fork?

thanks!

@opti
Copy link
Collaborator Author

opti commented Jan 5, 2015

@ipd yeah, the origin gem looks unmaintained for a while and I'm not sure it will be back on track. Anyway, I'm using my fork exactly with Rails 4.1.x. Didn't noticed any issues yet.

@ipd
Copy link

ipd commented Jan 5, 2015

@opti ok, thanks for getting back to me.

tors added a commit that referenced this pull request Jan 8, 2015
Update assets to jQuery-File-Upload 9.8.0
@tors tors merged commit 21e3de5 into tors:master Jan 8, 2015
@tors
Copy link
Owner

tors commented Jan 8, 2015

@opti Hola! Thanks for this! I've been very busy at work. I've added you as a collaborator.

@ipd
Copy link

ipd commented Jan 8, 2015

Thanks @tors !

We should probably version the gem so that people who are on rails < 4.x will be able to continue to use the old version.

Also, we should create a new example app for Rails 4.x.

@opti
Copy link
Collaborator Author

opti commented Jan 8, 2015

Thanks for merging this @tors

@opti
Copy link
Collaborator Author

opti commented Jan 8, 2015

hey @tors I've created a release tag v0.4.2, if you don't mind you can push it to rubygems

@tors
Copy link
Owner

tors commented Jan 9, 2015

@opti roger that! Thanks!

@felixbuenemann
Copy link
Collaborator

You should probably add back the X-Requested-WIth Patch for the Iframe-Transport Middleware before making a new release, see commit d246fe6 for details.

@opti
Copy link
Collaborator Author

opti commented Jan 9, 2015

@felixbuenemann I'm not sure that this is a good idea to make those changes in that repo. This js file is copied from original repo. Making fixes here forces repo maintainers to always keep in mind this fix on every future assets upgrade.
Maybe it make sense to open a pull request with this fix to the @blueimp's original jQuery-File-Upload repo.

@felixbuenemann
Copy link
Collaborator

Jepp, that's what I though and it was rejected, see blueimp/jQuery-File-Upload#3291. The problem is that this repo used to have this patch, so not having it brakes the usage of the iframe transport middleware.

Maybe the middleware could be changed to somehow detect the request without the extra header.

@opti
Copy link
Collaborator Author

opti commented Jan 9, 2015

@felixbuenemann I see. You're feel free to add it back while there is no another solution yet.

@felixbuenemann
Copy link
Collaborator

I think the best solution is to remove the middleware, see #69 for reasons.

@opti opti deleted the assets_v9.8.0 branch January 23, 2015 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants