-
-
Notifications
You must be signed in to change notification settings - Fork 50
modularize the code, more robust error handling and languages support #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| let curatorMode = false; | ||
| let apiUrl = DEFAULT_API_URL; | ||
| let language: SupportedLanguage = 'en'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set all three in constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are user-adjustable, thus not constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the defaults ;D
So the default apiURL comes from DEFAULT_API_URL in constants.ts, while language and curatorModes defaults are set here in state.s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can set them in state.ts if you prefer that. i think if i wanted to change them i would first look at constants.ts
|
The two duplicated IDs spotted by the quality gate are the last things I see, we can merge after fixing them |
|
shadowwwind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |




No description provided.