Skip to content

ci: Add test step in Deno #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2025
Merged

ci: Add test step in Deno #1109

merged 7 commits into from
Apr 3, 2025

Conversation

raon0211
Copy link
Collaborator

@raon0211 raon0211 commented Apr 3, 2025

No description provided.

@raon0211 raon0211 requested a review from dayongkr as a code owner April 3, 2025 10:14
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 0:21am

@raon0211 raon0211 changed the title chore: Deno chore: Add test step in Deno Apr 3, 2025
@raon0211 raon0211 changed the title chore: Add test step in Deno ci: Add test step in Deno Apr 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (3511f0a) to head (48c921d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         405      405           
  Lines        3541     3541           
  Branches     1048     1048           
=======================================
  Hits         3520     3520           
  Misses         21       21           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -21,5 +21,5 @@ declare let process:
* }
*/
export function isNode(): boolean {
return typeof process !== 'undefined' && process?.versions?.node != null;
return process?.versions?.node != null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this cause a reference error if the global process object is unavailable?

dayongkr
dayongkr previously approved these changes Apr 3, 2025
@raon0211 raon0211 merged commit 4be718e into main Apr 3, 2025
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants