Skip to content

feat(shuffle): Implement compact/shuffle #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2025
Merged

Conversation

Jeong-Rae
Copy link
Contributor

@Jeong-Rae Jeong-Rae commented Apr 4, 2025

Resolves: #1011

Implemented compact/shuffleas described in #1011

I included the lodash test cases provided in the issue, along with a few additional ones.

Test List

Test Coverage

Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2025 1:56pm

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (7de4438) to head (96c4193).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         410      411    +1     
  Lines        3603     3611    +8     
  Branches     1061     1064    +3     
=======================================
+ Hits         3582     3590    +8     
  Misses         21       21           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@dayongkr dayongkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!

I'll just fix the missing benchmark and some parts of the type annotations.

@dayongkr dayongkr merged commit 8334200 into toss:main Apr 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shuffle to compat package
4 participants