Skip to content

fix(compat): add guard for take/takeRight/defaults/repeat/words#1119

Merged
dayongkr merged 8 commits intotoss:mainfrom
D-Sketon:fix/guard
Apr 24, 2025
Merged

fix(compat): add guard for take/takeRight/defaults/repeat/words#1119
dayongkr merged 8 commits intotoss:mainfrom
D-Sketon:fix/guard

Conversation

@D-Sketon
Copy link
Contributor

@D-Sketon D-Sketon commented Apr 5, 2025

No description provided.

@vercel
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2025 4:19pm

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.31%. Comparing base (1068687) to head (b79c993).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   99.36%   99.31%   -0.06%     
==========================================
  Files         423      423              
  Lines        3770     3781      +11     
  Branches     1109     1116       +7     
==========================================
+ Hits         3746     3755       +9     
- Misses         24       26       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@dayongkr dayongkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!

@dayongkr dayongkr merged commit d7d8f2c into toss:main Apr 24, 2025
9 checks passed
@D-Sketon D-Sketon deleted the fix/guard branch July 17, 2025 16:46
@wo-o29
Copy link
Contributor

wo-o29 commented Oct 9, 2025

@D-Sketon

Hi! Could you please explain why the takeRight and take functions require the guard argument even though they are not from the compat module?

@D-Sketon
Copy link
Contributor Author

D-Sketon commented Oct 9, 2025

@wo-o29 I don't remember; I might have been confused about the compat and non-compat packages at the time.

@wo-o29
Copy link
Contributor

wo-o29 commented Oct 9, 2025

@wo-o29 I don't remember; I might have been confused about the compat and non-compat packages at the time.

Thank you for your reply.

I noticed that in the documentation for takeRight, there is no explanation for the third parameter (guard), yet it exists in the internal implementation. I was curious about the intent behind this, which is why I asked the above question.

@wo-o29
Copy link
Contributor

wo-o29 commented Oct 9, 2025

@dayongkr

Hello! I think take and takeRight should be removed because they are not compat modules and there is no explanation for the third argument (guard) in their respective documentation. I'd like to hear the maintainer's opinion🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants