Skip to content

feat(compat): implement zipWith #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 12, 2025
Merged

feat(compat): implement zipWith #1123

merged 8 commits into from
Apr 12, 2025

Conversation

D-Sketon
Copy link
Contributor

@D-Sketon D-Sketon commented Apr 6, 2025

close #999

Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2025 1:51pm

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.36%. Comparing base (7de4438) to head (c575b77).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   99.41%   99.36%   -0.06%     
==========================================
  Files         410      411       +1     
  Lines        3603     3616      +13     
  Branches     1061     1066       +5     
==========================================
+ Hits         3582     3593      +11     
- Misses         21       23       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dayongkr
Copy link
Collaborator

dayongkr commented Apr 12, 2025

Under Review:

  • Added test cases.
  • Added docs. (No document needed.)
  • Types
  • Check code readability.

}
return unzipToolkit(Array.from(array, value => Array.from(value)));
array = isArray(array) ? array : Array.from(array);
array = (array as T[][]).filter(item => isArrayLikeObject(item));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you apply a filter? Is it a more accurate implementation to filter out cases when it's not array-like??

Thank you for your contribution!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Copy link
Collaborator

@dayongkr dayongkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!

@dayongkr dayongkr merged commit 16d60d2 into toss:main Apr 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zipWith to compat package
4 participants