-
Notifications
You must be signed in to change notification settings - Fork 450
feat(compat): implement zipWith #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 99.41% 99.36% -0.06%
==========================================
Files 410 411 +1
Lines 3603 3616 +13
Branches 1061 1066 +5
==========================================
+ Hits 3582 3593 +11
- Misses 21 23 +2 🚀 New features to boost your workflow:
|
Under Review:
|
} | ||
return unzipToolkit(Array.from(array, value => Array.from(value))); | ||
array = isArray(array) ? array : Array.from(array); | ||
array = (array as T[][]).filter(item => isArrayLikeObject(item)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you apply a filter? Is it a more accurate implementation to filter out cases when it's not array-like??
Thank you for your contribution!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!!
close #999