Skip to content

fix(sample): include "undefined" in return union type #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(sample): include "undefined" in return union type #1302

wants to merge 3 commits into from

Conversation

@screendriver
Copy link

@screendriver screendriver commented Aug 8, 2025

sample() returns undefined when an empty array is given. This should also be reflected in the return type.

@vercel
Copy link

vercel bot commented Aug 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
es-toolkit Ready Ready Preview Comment Aug 17, 2025 10:45am

dayongkr
dayongkr approved these changes Aug 17, 2025
View reviewed changes
Copy link
Collaborator

@dayongkr dayongkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution!

@screendriver
Copy link
Author

screendriver commented Aug 17, 2025

Unfortunately I cannot merge because the deno CI job is pending and required.

@dayongkr
Copy link
Collaborator

dayongkr commented Aug 17, 2025

Since this involves a change to the interface, I haven’t merged it yet because I’d like to hear other maintainer’ opinion. I’ll leave another comment later this week.

@screendriver
Copy link
Author

screendriver commented Nov 3, 2025

I’ll leave another comment later this week

Since this is almost 3 months ago I just wanted to ask kindly if we can merge it @dayongkr ?

@dayongkr
Copy link
Collaborator

dayongkr commented Nov 5, 2025

Ah, this was put on hold per previous discussion with maintainers. Let me sync up and update.

@dayongkr
Copy link
Collaborator

dayongkr commented Nov 19, 2025

After thinking about it more, I think this needs to be addressed in the next major update, so I'll discuss internally about the timing of the next major release.

Sorry for making you wait so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dayongkr dayongkr dayongkr approved these changes

@raon0211 raon0211 Awaiting requested review from raon0211 raon0211 is a code owner

Assignees

No one assigned

Labels

next major p2: type enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@screendriver @dayongkr @raon0211