fix(sample): include "undefined" in return union type#1302
fix(sample): include "undefined" in return union type#1302screendriver wants to merge 3 commits intotoss:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dayongkr
left a comment
dayongkr
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for your contribution!
|
Unfortunately I cannot merge because the |
|
Since this involves a change to the interface, I haven’t merged it yet because I’d like to hear other maintainer’ opinion. I’ll leave another comment later this week. |
Since this is almost 3 months ago I just wanted to ask kindly if we can merge it @dayongkr ? |
|
Ah, this was put on hold per previous discussion with maintainers. Let me sync up and update. |
|
After thinking about it more, I think this needs to be addressed in the next major update, so I'll discuss internally about the timing of the next major release. Sorry for making you wait so long. |
3 participants
sample()returnsundefinedwhen an empty array is given. This should also be reflected in the return type.