Skip to content

Conversation

@wo-o29
Copy link
Contributor

@wo-o29 wo-o29 commented Nov 19, 2025

Summary

Fixes: #722

This PR adds a new "Package Manager" section to both English and Korean CONTRIBUTING guides to emphasize that the project uses Yarn 4 as its package manager. This helps new contributors avoid dependency conflicts by using the correct package manager from the start.

Changes

  • Added "Package Manager" section to .github/CONTRIBUTING.md (English version)
  • Added "패키지 매니저" section to .github/CONTRIBUTING-ko_kr.md (Korean version)
  • Both sections include:
    • Clear statement that the project uses Yarn 4
    • Instructions for getting started with Corepack
    • Step-by-step setup guide

Comment

If there is anything else I need to provide, please let me know!

Copilot AI review requested due to automatic review settings November 19, 2025 03:14
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
es-toolkit Ready Ready Preview Comment Nov 19, 2025 3:36am

Copilot finished reviewing on behalf of wo-o29 November 19, 2025 03:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds clear documentation about Yarn 4 as the project's package manager to help new contributors avoid dependency conflicts. The addition of a dedicated "Package Manager" section right after the Code of Conduct provides important setup information early in the contribution workflow.

Key Changes:

  • Added a new "Package Manager" section to both English and Korean CONTRIBUTING guides
  • Documented the use of Yarn 4 with Corepack for automatic version management
  • Provided step-by-step setup instructions for new contributors

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/CONTRIBUTING.md Added Package Manager section with Yarn 4 setup instructions including Corepack enablement and dependency installation steps
.github/CONTRIBUTING-ko_kr.md Added Korean translation of Package Manager section (패키지 매니저) with equivalent setup instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (b6ffb6d) to head (0f29326).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         474      474           
  Lines        4492     4492           
  Branches     1313     1313           
=======================================
  Hits         4491     4491           
  Misses          1        1           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@raon0211 raon0211 merged commit e00c448 into toss:main Nov 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backwards compatibility with yarn 1.x.x

3 participants