fix(compat/template): disable ES interpolation with custom 'interpolate' #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaviour is documented in Lodash examples at https://lodash.com/docs/4.17.15#template : ``` // Use the ES template literal delimiter as an "interpolate" delimiter. // Disable support by replacing the "interpolate" delimiter. ```
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot finished reviewing on behalf of
vbfox
November 20, 2025 15:14
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the template function to disable ES6 template literal interpolation (${...}) when a custom interpolate delimiter is specified in the options, matching Lodash's documented behavior.
Key changes:
- Extracted the default interpolate regex pattern into a named constant for reference comparison
- Modified the delimiter regex construction to enable ES6 template support only when using the default interpolate pattern (by reference equality)
- Added comprehensive tests to verify ES6 templates are disabled when custom interpolate delimiters are specified
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/compat/string/template.ts | Added defaultInterpolateRegExp constant and modified delimiter logic to use reference equality check for enabling ES6 template support |
| src/compat/string/template.spec.ts | Added test cases to verify ES6 template delimiters are properly disabled when custom interpolate patterns are provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dayongkr
approved these changes
Nov 26, 2025
Collaborator
dayongkr
left a comment
dayongkr
left a comment
There was a problem hiding this comment.
Thanks for your contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaviour is documented in Lodash examples at https://lodash.com/docs/4.17.15#template :
And implemented similarly:
https://github.com/lodash/lodash/blob/f299b52f39486275a9e6483b60a410e06520c538/lodash.js#L14864C27-L14864C39