test(compat/{negate,add,set}): fix duplicate test titles and enable 'vitest/no-identical-title' error #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vitest/no-identical-title' error
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sukvvon
commented
Nov 25, 2025
Comment on lines
-18
to
-24
| it('should create a function that negates the result of `func`', () => { | ||
| const negateFn = negate(isEven); | ||
|
|
||
| expect(negateFn(1)).toBe(true); | ||
| expect(negateFn(2)).toBe(false); | ||
| }); | ||
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 474 474
Lines 4492 4492
Branches 1313 1313
=======================================
Hits 4491 4491
Misses 1 1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
negate.spec.tsadd.spec.tsandset.spec.tsto be more specificvitest/no-identical-titleas error (remove from warn override)Changes
negate.spec.ts: Remove duplicated test caseadd.spec.ts: Differentiate test titles for positive, negative, and mixed number casesset.spec.ts: Differentiate test titles for nested path depths and object/array combinationseslint.config.mjs: Removevitest/no-identical-titlefrom warn rules (defaults to error)Screenshot
AS-IS
TO-BE