Skip to content

feat(values): add values in src/object#687

Closed
ankitjha420 wants to merge 3 commits intotoss:mainfrom
ankitjha420:feat/values
Closed

feat(values): add values in src/object#687
ankitjha420 wants to merge 3 commits intotoss:mainfrom
ankitjha420:feat/values

Conversation

@ankitjha420
Copy link
Contributor

This PR adds the function values. It was mentioned on the issue #669 and on the Compatibility documentation
Please let me know if there are any mistakes in my code, thanks <3

@ankitjha420 ankitjha420 requested a review from raon0211 as a code owner October 7, 2024 16:32
@vercel
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:37pm

@raon0211
Copy link
Collaborator

raon0211 commented Oct 22, 2024

Hello :) Thanks for your contribution! Meanwhile, I think we have a good native API called Object.values(...), why not add this into our compatibility library es-toolkit/compat?

You can refer to functions like ceil to check how we handle these kinds of functions.

@raon0211
Copy link
Collaborator

raon0211 commented Apr 3, 2025

Closing the pull request because of inactivity. Feel free to open a new one :)

@raon0211 raon0211 closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants