-
Notifications
You must be signed in to change notification settings - Fork 43
fix: supports unicode property escape step #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gronxb
wants to merge
11
commits into
main
Choose a base branch
from
fix/emoji-regex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
98c77f9
fix: supports unicode property escape step
gronxb 7bf5412
feat: changeset
gronxb fe542bb
fix: about
gronxb 3198983
fix: rolblack
gronxb ee8efe0
fix
gronxb 28200c7
fix:iont
gronxb 088bee2
[autofix.ci] apply automated fixes
autofix-ci[bot] 794a95e
fix: types
gronxb 8aad863
fix
gronxb 53844cd
fix
gronxb 0e9b4a4
fix: types
gronxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@granite-js/react-native': patch | ||
| '@granite-js/plugin-core': patch | ||
| '@granite-js/native': patch | ||
| '@granite-js/mpack': patch | ||
| --- | ||
|
|
||
| fix: supports unicode property escape step |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 0 additions & 98 deletions
98
packages/mpack/src/bundler/plugins/transformPlugin/steps/createFullyTransformStep.ts
This file was deleted.
Oops, something went wrong.
32 changes: 32 additions & 0 deletions
32
...ack/src/bundler/plugins/transformPlugin/steps/createTransformUnicodePropertyEscapeStep.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { transformSync } from '@babel/core'; | ||
| import { AsyncTransformStep } from '../../../../transformer/TransformPipeline'; | ||
| import { defineStepName } from '../../../../utils/defineStepName'; | ||
|
|
||
| export function createTransformUnicodePropertyEscapeStep(): AsyncTransformStep { | ||
| const unicodePropertyEscapeRegExp = /\\p\{[^}]+\}/u; | ||
|
|
||
| const transformUnicodePropertyEscapeStep: AsyncTransformStep = async (code, args) => { | ||
| if (!unicodePropertyEscapeRegExp.test(code)) { | ||
| return { code }; | ||
| } | ||
|
|
||
| const result = transformSync(code, { | ||
| presets: [require.resolve('@babel/preset-typescript')], | ||
| plugins: [require.resolve('@babel/plugin-transform-unicode-regex')], | ||
| filename: args.path, | ||
| sourceMaps: false, | ||
| babelrc: false, | ||
| configFile: false, | ||
| }); | ||
|
|
||
| if (result?.code != null) { | ||
| return { code: result.code }; | ||
| } | ||
|
|
||
| return { code }; | ||
| }; | ||
|
|
||
| defineStepName(transformUnicodePropertyEscapeStep, 'transform-unicode-property-escape'); | ||
|
|
||
| return transformUnicodePropertyEscapeStep; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supports valibot and zod