-
Notifications
You must be signed in to change notification settings - Fork 81
feat(react): Rename ErrorBoundary onError to onCatch (BREAKING CHANGE)
#1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: manudeli <[email protected]>
Co-authored-by: manudeli <[email protected]>
People can be co-author:
|
Co-authored-by: manudeli <[email protected]>
| .ErrorBoundary({ | ||
| fallback: ({ error }) => <>{error.message}</>, | ||
| onError: logger.log, | ||
| onCatch: logger.log, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot This is a migration guide from v1 to v2. Please do not do this.
Not only this MDX, but other migration docs should also be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the changes to both English and Korean v1-to-v2 migration docs. These docs should remain unchanged as they document the historical migration from v1 to v2. (commit e5cc944)
onError to onCatch (BREAKING CHANGE)
|
Size Change: -12 B (-0.01%) Total Size: 80.2 kB
ℹ️ View Unchanged
|
Co-authored-by: manudeli <[email protected]>
|
@copilot |
Co-authored-by: manudeli <[email protected]>
Created migrate-to-v4 migration guides for both English and Korean following the same format as other migration guides. The guides document the |
…h renaming in English and Korean documentation
onErrorprop toonCatchin ErrorBoundary types (ErrorBoundaryProps)onCatchinstead ofonErroronCatchinstead ofonErrorUpdate migration documentation (migrate-to-v2.mdx for both en and ko)Reverted - v1-to-v2 migration docs should remain unchangedonErrortoonCatch(both English and Korean)onCatchAll changes have been successfully completed! The ErrorBoundary component now uses
onCatchinstead ofonErroras the prop name, which better aligns with the naming convention (matchingshouldCatchandcomponentDidCatch).Migration Guide
A comprehensive migrate-to-v4 guide has been added to help users transition from
onErrortoonCatch. The guide includes:ErrorBoundary.withpatternNote: The v1-to-v2 migration documentation has been kept unchanged as it documents historical migration from v1 to v2, not current v4 changes.
Fixes #1783
Original prompt
Fixes #1783
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.