-
Notifications
You must be signed in to change notification settings - Fork 81
Add timeout documentation example for QueriesHydration #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: manudeli <[email protected]>
Co-authored-by: manudeli <[email protected]>
Co-authored-by: manudeli <[email protected]>
|
@copilot timeout should be implement by library user not prop with Could you remove new interface but add this example in QueriesHydration docs? |
People can be co-author:
|
…d timeout Co-authored-by: manudeli <[email protected]>
Removed the |
|
@copilot rebase this branch, This paragraph also should be added in suspensive.org |
Co-authored-by: manudeli <[email protected]>
Added the timeout documentation to suspensive.org in both English and Korean. Commit: 55d2231 Note: I cannot rebase branches as force push is not allowed in my environment. If you need a rebase, please do it manually. |
|
@copilot Ah,,, This shouldn't be worked...! do we have to make prop? |
|
Size Change: +144 B (+0.17%) Total Size: 86.8 kB
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
=========================================
+ Coverage 0 93.38% +93.38%
=========================================
Files 0 44 +44
Lines 0 710 +710
Branches 0 177 +177
=========================================
+ Hits 0 663 +663
- Misses 0 41 +41
- Partials 0 6 +6
🚀 New features to boost your workflow:
|
Could you clarify what isn't working with the |
|
@copilot How about this <QueriesHydration queries={timeoutQueries([userQueryOptions(), postsQueryOptions()], { ms: 2000 })}> ? |
Your comment appears to be incomplete - could you please share what you had in mind? I'd be happy to implement your suggestion once I understand it. |
|
@copilot This is example what I want <QueriesHydration
queries={[userQueryOptions(), postsQueryOptions()].map((query) => timeoutOptions(query, { ms: 2000 }))}
>
...
</QueriesHydration> |
... The code block appears to be empty. Could you please share the example again? |
|
@copilot This is example what I want <QueriesHydration
queries={[userQueryOptions(), postsQueryOptions()].map((query) => timeoutOptions(query, { ms: 2000 }))}
>
</QueriesHydration> |
... The code block is still showing as empty. This might be a GitHub formatting issue. Could you try sharing the code in a different way, perhaps as a gist link or by using different formatting? |
Overview
Adds documentation example showing how to implement timeout for
QueriesHydrationcomponent in@suspensive/react-query-4and@suspensive/react-query-5using user-implementedqueryOptions.Based on maintainer feedback, timeout functionality should be implemented by library users via
queryOptionsrather than as a built-in prop. This PR adds documentation examples demonstrating the recommended pattern in both JSDoc and suspensive.org documentation.Note: Awaiting maintainer feedback on the final implementation approach. The maintainer's code examples are appearing as empty code blocks - clarification has been requested.
Usage Example
Queries exceeding the timeout will trigger an error and fall back to client-side rendering (default
skipSsrOnErrorbehavior) or proceed based on configuration.Changes Made
QueriesHydrationcomponent in@suspensive/react-query-4and@suspensive/react-query-5PR Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.