Skip to content

fix: DocExample Layout #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix: DocExample Layout #16

merged 1 commit into from
May 12, 2025

Conversation

minai621
Copy link
Member

@minai621 minai621 commented May 9, 2025

수정한 내용

DocExample 컴포넌트에서 반응형 레이아웃이 깨지는 부분을 수정했어요.
https://github.com/toss/technical-writing/pull/10/files << 해당 PR의 영향으로 발생한 것 같아 해당 변경을 다시 원래의 코드로 돌려두고

  1. grid-template-columns: 1fr 1fr; -> grid-template-columns: 6fr 4fr;
  2. .codePanelmin-width: 600px도 삭제했어요.

🚨 prettier에서 불필요한 indent를 없애면서 변경이 많이 잡힙니다.

2025-05-09.2.36.32.mov

이 변경이 필요한 이유 (선택)

체크리스트

  • 문서 가이드에 맞게 작성했어요.
  • 기존 설명 흐름을 해치지 않고 자연스럽게 연결되도록 구성했어요.
  • 오타나 잘못된 정보는 없는지 검토했어요.
  • 관련된 이슈가 있다면 아래에 연결했어요.

@minai621 minai621 requested a review from raon0211 May 9, 2025 05:41
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
technical-writing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 5:41am

@minai621 minai621 changed the title DocExample 컴포넌트에서 반응형 레이아웃이 깨지는 부분을 수정했어요. fix: DocExample Layout May 12, 2025
@minai621 minai621 merged commit 73f16c1 into toss:master May 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants