Constantify serve_{dir,file} test file paths and content #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly a QoL change for downstream packagers, but might also prove useful for e.g. future refactors. Currently we have to patch all those file paths to something exsistent, due to test-files/ not being included in crates.io releases, while the Debian Rust Team pulls Rust crate source from there: https://salsa.debian.org/rust-team/debcargo-conf/-/blob/ee75c0c18a/src/tower-http/debian/patches/missing-testdata With these constants we could change only them. Test files are also changed to the same content, so one constant fits all.
nc7s
force-pushed
the
constantify-test-names
branch
from
6aa0bef to
cf9c6be
Compare
|
Hey. I understand you're trying to solve a real issue here, but I'm not a fan of this diff. Why do you run these tests when packaging? |
|
We frequently patch code in distros, so running tests there make sure our patches don't break things. The diff - sure could be improved. Now that Debian's in freeze, it's not any urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mainly a QoL change for downstream packagers, but might also prove useful for e.g. future refactors.
Currently we have to patch all those file paths to something exsistent, due to test-files/ not being included in crates.io releases, while the Debian Rust Team pulls Rust crate source from there.
Solution
With these constants we could change only them.
Test files are also changed to the same content, so one constant fits all.