ensure that re-exported symbols show feature label in root#754
Merged
tobz merged 5 commits intotower-rs:masterfrom Jul 20, 2024
Merged
ensure that re-exported symbols show feature label in root#754tobz merged 5 commits intotower-rs:masterfrom
tobz merged 5 commits intotower-rs:masterfrom
Conversation
jplatte
reviewed
Dec 5, 2023
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Have you tested this? We are already using doc_auto_cfg so I don't think these doc(cfg) attributes should make a difference. If my memory serves me right, it might instead help to put the doc(cfg) on the definition of those items, rather than the re-exports.
Contributor
Author
|
@jplatte in my test it didn't show up before and it did show after (locally using the right --cfg flags etc). Whether it's the right solution I do not know. Feel free to propose or guide me into doing something different if you think I approached it wrong. |
Member
|
Okay, if you did test it then I have no concerns. |
tobz
approved these changes
Jul 20, 2024
tobz
added
C-enhancement
tobz
added
the
S-awaiting-release
Member
|
This has been released as part of Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #743