Skip to content

Customize Client Identifier via LocalStorage #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: releaseCandidate
Choose a base branch
from

Conversation

dmoruzzi
Copy link
Contributor

@dmoruzzi dmoruzzi commented Jun 1, 2025

Describe your changes

This introduces the ability to override the default clientId in the sforce-call-options header. Before this change, the default value is always client=Salesforce Inspector Reloaded. After this change, users can insert a key called "ClientId" in the browser's LocalStorage to dynamically set any value for the client. Empty value with key will be treated as null by Salesforce.

  1. This enhances the development of this extension by allowing me to easily self-document in the API call itself.
  2. Testing teams can set ClientId easily to enhance traceability of queries in the ApiEvent records.

Issue ticket number and link

Feature 504

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@tprouvot
Copy link
Owner

tprouvot commented Jun 2, 2025

Hi @dmoruzzi,
I understand that you want to define your own clientId with this PR. What I don't really get is why this should be merged in the extension ?

Keeping the local update without merging them is not convenient ?
Are you working on some features that requires a particular analysis of the api calls ?

I would prefer end users not able to update this clientId, and the fact that you did not exposed this in the options is a good thing, I would also remove all documentation (CHANGES.md, screenshot, how-to) about this and let only advanced users customize the value.

@dmoruzzi
Copy link
Contributor Author

dmoruzzi commented Jun 2, 2025 via email

@tprouvot
Copy link
Owner

tprouvot commented Jun 2, 2025

I'm OK with keeping this one opened, you just need to remove the documentation.
I like the idea of keeping SIR as clientId prefix ("Salesforce Inspector Reloaded/{variableClientId}") 👍

@tprouvot
Copy link
Owner

Hi @dmoruzzi
Did you had a chance to read my last comment ?

@dmoruzzi
Copy link
Contributor Author

dmoruzzi commented Jun 24, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants