-
-
Notifications
You must be signed in to change notification settings - Fork 123
Customize Client Identifier via LocalStorage #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: releaseCandidate
Are you sure you want to change the base?
Customize Client Identifier via LocalStorage #866
Conversation
Hi @dmoruzzi, Keeping the local update without merging them is not convenient ? I would prefer end users not able to update this clientId, and the fact that you did not exposed this in the options is a good thing, I would also remove all documentation (CHANGES.md, screenshot, how-to) about this and let only advanced users customize the value. |
Are you working on some features that requires a particular analysis of
the api calls ?
Not as a part of this extension. My use case is we send all of the ApiEvent
records to datadog. Occasionally we need to audit the testing results, and
having a unique ClientId per testing situation would easily allow these
adhoc runs to be filtered.
I was thinking about adding a page to download the most recent
ApiTotalUsage report and getting a catalog of users/client/usage. But the
CSV format can become too large for production organizations that we
pivoted. We ultimately just put that data into a Confluence webpage
instead.
In regards to the documentation, we can remove it and only expose to
advance users. This would still be an enhancement compared to our team
modifying the JS file and then reloading the extension.
Would you prefer we closed this instead?
Alternatively we could do something like simple_salesforce and add an
option and prefix with "Salesforce Inspector Reloaded/{variableClientId}"?
This keeps the use case of identifying API calls while still allowing quick
filtering.
…On Mon, Jun 2, 2025, 4:17 AM Thomas Prouvot ***@***.***> wrote:
*tprouvot* left a comment (tprouvot/Salesforce-Inspector-reloaded#866)
<#866 (comment)>
Hi @dmoruzzi <https://github.com/dmoruzzi>,
I understand that you want to define your own clientId with this PR. What
I don't really get is why this should be merged in the extension ?
Keeping the local update without merging them is not convenient ?
Are you working on some features that requires a particular analysis of
the api calls ?
I would prefer end users not able to update this clientId, and the fact
that you did not exposed this in the options is a good thing, I would also
remove all documentation (CHANGES.md, screenshot, how-to) about this and
let only advanced users customize the value.
—
Reply to this email directly, view it on GitHub
<#866 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFK6CXYGMUQW7YMTXQJD3BL3BQCABAVCNFSM6AAAAAB6KRQY4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMRZGM3TENBVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm OK with keeping this one opened, you just need to remove the documentation. |
Hi @dmoruzzi |
Hello. I have read this message and I agree with it. I just haven't found
the time, I've been swamped with work. Thank you :)
…On Tue, Jun 24, 2025, 12:28 PM Thomas Prouvot ***@***.***> wrote:
*tprouvot* left a comment (tprouvot/Salesforce-Inspector-reloaded#866)
<#866 (comment)>
Hi @dmoruzzi <https://github.com/dmoruzzi>
Did you had a chance to read my last comment ?
—
Reply to this email directly, view it on GitHub
<#866 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFK6CX5XLZXAUFAFE3J6EXL3FF4EBAVCNFSM6AAAAAB6KRQY4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMBRGE2DAMZVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Describe your changes
This introduces the ability to override the default clientId in the
sforce-call-options
header. Before this change, the default value is alwaysclient=Salesforce Inspector Reloaded
. After this change, users can insert a key called "ClientId" in the browser's LocalStorage to dynamically set any value for the client. Emptyvalue
with key will be treated as null by Salesforce.Issue ticket number and link
Feature 504
Checklist before requesting a review