Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support redactor 10, add bower, gulp and numerous other enhancements #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update to support redactor 10, add bower, gulp and numerous other enhancements #17

wants to merge 5 commits into from

Conversation

thebitguru
Copy link

Hi Jason,

Here is the first pull request for redactor 10 upgrade. A few things to point out.

  1. bower.json needs to point to the correct homepage.
  2. I haven't published this in the bower repo because I am thinking that it should probably point to your repo. I am ready to add it to my local project so ideally we can publish this in bower soon. I will reference the local git checkout until then.
  3. Overview section in README.md needs to be updated if you end up accepting this PR.
  4. I changed the colors and styling, and moved to less. I know there are better ways to do that by using variables and less' lazy loading. I can help with that.
  5. I added "redactor-" prefix to the file names.
  6. Added gulpfile to bring this all together.

@thebitguru
* Added bower.json and package.json in prep for publishing to bower r…
2bae9ba 
…epo.

* Created gulp config to watch and compile.
* Added minified versions of css and js.
@thebitguru
* Now using redactor-mentions.* as the file names instead of mentions…
714c32b 
….{css,js}. Plugin is still invoked as 'mentions' within redactor.

 * Plugin working in redactor 10.
@thebitguru
Floating div by the caret!
4198815 
 * Moved the select inside a container div that now floats beneath the caret (much more intuitive)
 * Changed the css to a less file.
 * The options are now specified in a `mentions` object instead of the base options object.  See updated readme for example.
@thebitguru
* Testing code highlight in github.
eef052a
@thebitguru
Added support for specifying custom format functions for mention list…
6423509 
… and actual mention.

 * Reverted server side searching changes in README.md (didn't implemented it yet).
 * Added support for specifying a custom mention item compose function.
 * Added support for specifying a custom link display function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thebitguru