Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add API to get channel info from channel path and get channel path from channel id #2476

Merged
merged 8 commits into from
Nov 3, 2024
Merged

feat: add API to get channel info from channel path and get channel path from channel id #2476

merged 8 commits into from
Nov 3, 2024

Conversation

Eraxyso
Copy link
Contributor

@Eraxyso Eraxyso commented Jul 3, 2024 •
edited
Loading

Closes #2356

@Eraxyso Eraxyso marked this pull request as draft July 3, 2024 23:31
@Eraxyso Eraxyso marked this pull request as ready for review July 6, 2024 15:57
@Eraxyso Eraxyso requested a review from pikachu0310 July 6, 2024 15:58
@Eraxyso Eraxyso changed the title Feat: add API to get channel info from channel path and get channel path from channel id feat: add API to get channel info from channel path and get channel path from channel id Jul 8, 2024
@pikachu0310
Copy link
Contributor

遅れててごめんなさい、近いうちに見ます。

@ramdos0207 ramdos0207 self-requested a review October 19, 2024 11:51
ramdos0207
ramdos0207 requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@ramdos0207 ramdos0207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/channelsの実装は完璧です！ただ、/channels/{channelID}/pathの方は数カ所気になるポイントがあったのでコメントしました。確認をお願いします！

router/v3/channels.go Outdated Show resolved Hide resolved
docs/v3-api.yaml Outdated Show resolved Hide resolved
docs/v3-api.yaml Outdated Show resolved Hide resolved
docs/v3-api.yaml Outdated Show resolved Hide resolved
@Eraxyso
Copy link
Contributor Author

Eraxyso commented Nov 2, 2024

ご指摘いただいたところを修正しました

@ramdos0207
Copy link
Contributor

完璧です！マージします

@ramdos0207 ramdos0207 merged commit c3dae37 into traPtitech:master Nov 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramdos0207 ramdos0207 ramdos0207 approved these changes

@pikachu0310 pikachu0310 Awaiting requested review from pikachu0310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

チャンネル名とチャンネルのIDを相互引けるAPIが欲しい
3 participants
@Eraxyso @pikachu0310 @ramdos0207