-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable udeps checking till all unused deps are resolved #969
Disable udeps checking till all unused deps are resolved #969
Conversation
Instead of disabling the check, we can mark the false-positivies as we have done here https://github.com/Tracel-AI/burn/blob/e5c6044062050bcee74d1e15369c9763ad7dd736/burn-dataset/Cargo.toml#L55-L56 in the specific crate. I guess the problem is that 7154755#diff-b1776cd66202f5cfa4b0878c00a6cc9fe41d82b86e303b2c7f485c5877b5e998R22 is not used in the code, that's why it is marked as unused dep. If we remove that dep, can the example be built the same? |
@nathanielsimard @Luni-4 this is a blocker. It takes too long to resolve all the issues. Lets disable it first and enable in another PR. I am not even sure how it was possible to enable it in the first place if there were unused dependencies in the first place. Pretty much most are false positive. My personal take is that we should not enforce upon PR check but rather audit the code time to time because the tooling of udep is huge to install on users computer and it finds too many false positive. Having an unused dependency for a short period is not super urgent. |
All right. Can we move this check into the |
@Luni-4 it is a great idea! I will update the PR. |
I think it might cause a headache if we do this right before the release. Actions support scheduled scan. I think we should schedule it similar to other security scans. |
I filed a ticket (#975) to take up and fix enabling in other issue. |
Pull Request Template
Changes
udeps is failing the current main branch since there are many false positives are unresolved.