Refactor/cube/vectorization #4183
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (5)
crates/burn-cube/src/codegen/dialect/procedure/read.rs|146 col 40| error: useless conversion to the same type: u8
--> crates/burn-cube/src/codegen/dialect/procedure/read.rs:146:40
|
146 | let vectorization_factor: u8 = self.tensors[0].item().vectorization.into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into()
: self.tensors[0].item().vectorization
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: -D clippy::useless-conversion
implied by -D warnings
= help: to override -D warnings
add #[allow(clippy::useless_conversion)]
crates/burn-cube/src/codegen/dialect/vectorization.rs|167 col 29| error: useless conversion to the same type: u8
--> crates/burn-cube/src/codegen/dialect/vectorization.rs:167:29
|
167 | let vectorize: u8 = vectorize.into();
| ^^^^^^^^^^^^^^^^ help: consider removing .into()
: vectorize
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
crates/burn-cube/src/language/element/bool.rs|42 col 9| error: useless conversion to the same type: u8
--> crates/burn-cube/src/language/element/bool.rs:42:9
|
42 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into()
: self.vectorization
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
crates/burn-cube/src/language/element/numeric.rs|41 col 28| error: useless conversion to the same type: u8
--> crates/burn-cube/src/language/element/numeric.rs:41:28
|
41 | vectorization: (vec.len() as u8).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into()
: (vec.len() as u8)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
crates/burn-cube/src/language/element/uint.rs|26 col 9| error: useless conversion to the same type: u8
--> crates/burn-cube/src/language/element/uint.rs:26:9
|
26 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing .into()
: self.vectorization
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Filtered Findings (0)
Annotations
Check failure on line 146 in crates/burn-cube/src/codegen/dialect/procedure/read.rs
github-actions / clippy
[clippy] crates/burn-cube/src/codegen/dialect/procedure/read.rs#L146
error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/codegen/dialect/procedure/read.rs:146:40
|
146 | let vectorization_factor: u8 = self.tensors[0].item().vectorization.into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tensors[0].item().vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
Raw output
crates/burn-cube/src/codegen/dialect/procedure/read.rs:146:40:e:error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/codegen/dialect/procedure/read.rs:146:40
|
146 | let vectorization_factor: u8 = self.tensors[0].item().vectorization.into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tensors[0].item().vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
__END__
Check failure on line 167 in crates/burn-cube/src/codegen/dialect/vectorization.rs
github-actions / clippy
[clippy] crates/burn-cube/src/codegen/dialect/vectorization.rs#L167
error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/codegen/dialect/vectorization.rs:167:29
|
167 | let vectorize: u8 = vectorize.into();
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `vectorize`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Raw output
crates/burn-cube/src/codegen/dialect/vectorization.rs:167:29:e:error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/codegen/dialect/vectorization.rs:167:29
|
167 | let vectorize: u8 = vectorize.into();
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `vectorize`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
__END__
Check failure on line 42 in crates/burn-cube/src/language/element/bool.rs
github-actions / clippy
[clippy] crates/burn-cube/src/language/element/bool.rs#L42
error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/bool.rs:42:9
|
42 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Raw output
crates/burn-cube/src/language/element/bool.rs:42:9:e:error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/bool.rs:42:9
|
42 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
__END__
Check failure on line 41 in crates/burn-cube/src/language/element/numeric.rs
github-actions / clippy
[clippy] crates/burn-cube/src/language/element/numeric.rs#L41
error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/numeric.rs:41:28
|
41 | vectorization: (vec.len() as u8).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(vec.len() as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Raw output
crates/burn-cube/src/language/element/numeric.rs:41:28:e:error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/numeric.rs:41:28
|
41 | vectorization: (vec.len() as u8).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(vec.len() as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
__END__
Check failure on line 26 in crates/burn-cube/src/language/element/uint.rs
github-actions / clippy
[clippy] crates/burn-cube/src/language/element/uint.rs#L26
error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/uint.rs:26:9
|
26 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Raw output
crates/burn-cube/src/language/element/uint.rs:26:9:e:error: useless conversion to the same type: `u8`
--> crates/burn-cube/src/language/element/uint.rs:26:9
|
26 | self.vectorization.into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.vectorization`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
__END__