Add Test target + Support sha256 revisions #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new test target and enhances OCIURL parsing to support tags containing colons (e.g., SHA256 revisions).
- Introduce
CiliconTeststarget and integrate it into the Xcode project and scheme. - Update
OCIURLinitializer to correctly handle tags with multiple colon-separated components. - Supply unit tests covering both standard tags and SHA256-style revisions.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CiliconTests/OCI/Model/OCIURLTests.swift | New tests for OCIURL init and JSON encoding |
| Cilicon/OCI/Model/OCIURL.swift | Changed path.split(separator: ":") logic for tags |
| Cilicon.xcodeproj/xcshareddata/xcschemes/... | Added CiliconTests to scheme testables |
| Cilicon.xcodeproj/project.pbxproj | Added CiliconTests target and related build entries |
Comments suppressed due to low confidence (1)
CiliconTests/OCI/Model/OCIURLTests.swift:44
- [nitpick] Consider adding a test for encoding an
OCIURLwhose tag contains a colon (e.g., asha256revision) to ensure JSON encoding handles that scenario correctly.
func test_encode() throws {
Marcocanc
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilicon.xcodeproj/project.pbxprojMotivation
The revisions of tags of https://github.com/cirruslabs/macos-image-templates/pkgs/container/macos-runner/versions change often. This change makes it possible to pin a septic version in the config file.
Example